[webkit-reviews] review granted: [Bug 80668] [GTK] Menulist buttons have separators even when the theme turns them off : [Attachment 130952] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 80668: [GTK] Menulist buttons have separators even when the theme turns
them off
https://bugs.webkit.org/show_bug.cgi?id=80668

Attachment 130952: Patch
https://bugs.webkit.org/attachment.cgi?id=130952&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130952&action=review


This patch looks reasonable to me. That being said, feel free to get a more
formal review from another GTK expert.

> Source/WebCore/ChangeLog:10
> +	   No new tests. GTK+ theme differences are notoriously difficult
> +	   to test, because consistent results depend on having certain themes
> +	   certain versions of themes installed.

The second sentence doesn't read well. I think it may read better if you remove
the phrase "certain themes".