[webkit-reviews] review requested: [Bug 79385] REGRESSION (r99369): File input button doesn't highlight when pressed : [Attachment 131195] Patch and layout tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 10 17:30:14 PST 2012


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 79385: REGRESSION (r99369): File input button doesn't highlight when
pressed
https://bugs.webkit.org/show_bug.cgi?id=79385

Attachment 131195: Patch and layout tests
https://bugs.webkit.org/attachment.cgi?id=131195&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Renamed m_lastCanReceiveDroppedFilesState to m_canReceiveDroppedFiles and
modified the RenderFileUploadControl constructor to initialize this instance
variable with the value of HTMLInputElement::canReceiveDroppedFiles().

On another note, the name "canReceiveDroppedFiles" doesn't sufficiently
describe its purpose. HTMLInputElement::canReceiveDroppedFiles() returns true
when a person is hovering a dragged file(s) over an <input type="file"> and
false otherwise. I can't think of a good name at the moment. Maybe a name that
incorporates words/phrases such as "hovering", or "drag entered"?

For completeness, the layout test is a pixel test and passes using an Apple Mac
WebKit build on my MacBook Pro running 10.7.3. I'll rebaseline the results for
the non-Apple Mac ports upon landing this patch.


More information about the webkit-reviews mailing list