[webkit-reviews] review granted: [Bug 78872] [chromium] ScrollbarLayerChromium/CCScrollbarLayerImpl for CC-side scrollbar painting : [Attachment 130677] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Tien-Ren Chen
<trchen at chromium.org>'s request for review:
Bug 78872: [chromium] ScrollbarLayerChromium/CCScrollbarLayerImpl for CC-side
scrollbar painting
https://bugs.webkit.org/show_bug.cgi?id=78872

Attachment 130677: Patch
https://bugs.webkit.org/attachment.cgi?id=130677&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130677&action=review


Nice, and clean EWS to boot. R=me, just need to fix up some comments and put
this back behind the thread guard to land.

> Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:90
> +    if (scrollbar->isCustomScrollbar() /* || !CCProxy::hasImplThread() */) {
// FIXME: also filter out single thread case when we

think we need to uncomment this check before landing

> Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:107
> +    if (!scrollLayer) // FIXME: sometimes we get called before
setScrollLayer, workaround by finding out ourself

comment isn't quite right - typo in "ourself" and lacks a period at the end
(same goes for the one on line 119)