[webkit-reviews] review denied: [Bug 80501] Remove Node::isContentElement and Node::isShadowElement : [Attachment 130777] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 7 23:43:34 PST 2012


Hajime Morrita <morrita at google.com> has denied Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 80501: Remove Node::isContentElement and Node::isShadowElement
https://bugs.webkit.org/show_bug.cgi?id=80501

Attachment 130777: Patch
https://bugs.webkit.org/attachment.cgi?id=130777&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=130777&action=review


> Source/WebCore/html/shadow/InsertionPoint.h:54
> +    virtual bool isInsertionPoint() const { return true; }

OVERRIDE here.

> Source/WebCore/html/shadow/InsertionPoint.h:77
> +    // https://bugs.webkit.org/show_bug.cgi?id=78596

It looks we don't need something special for <shadow>.


More information about the webkit-reviews mailing list