[webkit-reviews] review requested: [Bug 80199] [chromium] Make compositeAndReadback and damage tracking play nicely together : [Attachment 130436] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 6 13:51:10 PST 2012
Shawn Singh <shawnsingh at chromium.org> has asked for review:
Bug 80199: [chromium] Make compositeAndReadback and damage tracking play nicely
together
https://bugs.webkit.org/show_bug.cgi?id=80199
Attachment 130436: Patch
https://bugs.webkit.org/attachment.cgi?id=130436&action=review
------- Additional Comments from Shawn Singh <shawnsingh at chromium.org>
The fix is trivial, but testing it is not so obvious. Testing this fix
requires observing front-buffer changes. As I understand, this could be done
via chromium browser gpu pixel tests, but it won't happen in layout tests or
webkit_unit_tests. Is it worth going through that trouble? ... also, I think
context lost issues are already addressed by the existing code in
compositeAndReadback (exits early if doComposite returns false).
More information about the webkit-reviews
mailing list