[webkit-reviews] review granted: [Bug 79068] SVG should support transform-origin and relative values : [Attachment 130431] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 79068: SVG should support transform-origin and relative values
https://bugs.webkit.org/show_bug.cgi?id=79068

Attachment 130431: Patch
https://bugs.webkit.org/attachment.cgi?id=130431&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=130431&action=review


> Source/WebCore/rendering/style/RenderStyle.cpp:798
> +    bool applyTransformOrigin =
requireTransformOrigin(rareNonInheritedData->m_transform->m_operations,
applyOrigin);

I think it would be worth having a local const reference to
rareNonInheritedData->m_transform->m_operations, to avoid two de-refs every
time you use the operations list.

> Source/WebCore/rendering/style/RenderStyle.cpp:813
> +    bool applyTransformOrigin =
requireTransformOrigin(rareNonInheritedData->m_transform->m_operations,
applyOrigin);

ditto.