[webkit-reviews] review granted: [Bug 80375] Make CSSStyleSelector::convertToLength() behave more like CSSPrimitiveValue::convertToLength(). : [Attachment 130279] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 5 21:58:37 PST 2012


Eric Seidel <eric at webkit.org> has granted Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 80375: Make CSSStyleSelector::convertToLength() behave more like
CSSPrimitiveValue::convertToLength().
https://bugs.webkit.org/show_bug.cgi?id=80375

Attachment 130279: Patch
https://bugs.webkit.org/attachment.cgi?id=130279&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I like this, but we should just early return now, since we don't need to fal
through to the return l.

Do we know if this has a perf effect?  (I kinda doubt it would).


More information about the webkit-reviews mailing list