[webkit-reviews] review granted: [Bug 80275] Web Inspector: [Regression] Message bubbles are not removed from scripts panel source frames after console was cleared. : [Attachment 130133] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 80275: Web Inspector: [Regression] Message bubbles are not removed from
scripts panel source frames after console was cleared.
https://bugs.webkit.org/show_bug.cgi?id=80275

Attachment 130133: Patch
https://bugs.webkit.org/attachment.cgi?id=130133&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130133&action=review


> Source/WebCore/inspector/front-end/ScriptsPanel.js:297
> +	   var sourceFrames = this._sourceFramesByUISourceCode.values();

This sounds more like compilation error rather than semantics error. Can we
annotate the map interaction so that the compiler could catch such errors?