[webkit-reviews] review granted: [Bug 90255] JSObject wastes too much memory on unused property slots : [Attachment 150108] the patch

[bugzilla-daemon at webkit.org]

Mark Hahnenberg <mhahnenberg at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 90255: JSObject wastes too much memory on unused property slots
https://bugs.webkit.org/show_bug.cgi?id=90255

Attachment 150108: the patch
https://bugs.webkit.org/attachment.cgi?id=150108&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=150108&action=review


Overall, looks good. r=me with suggestions :-)

> Source/JavaScriptCore/runtime/JSObject.h:351
> +#if JSNonFinalObject_inlineStorageCapacity

I guess this is to make it easier if we want to change back to non-zero inline
storage for JSNonFinalObjects in the future?

> Source/JavaScriptCore/runtime/JSObject.h:361
> +		   globalData, structure,

Why on a separate line?

> Source/JavaScriptCore/runtime/JSObject.h:574
> +    if (propertyStorageCapacity() == inlineStorageCapacity())

You could assert that propertyStorageCapacity() >= inlineStorageCapacity() at
the beginning of the function and then return propertyStorageCapacity() ==
inlineStorageCapacity(). Two less lines!