[webkit-reviews] review denied: [Bug 90284] [GTK] WebKit test runner ignores all system environment variables : [Attachment 150189] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 29 09:16:21 PDT 2012


Dirk Pranke <dpranke at chromium.org> has denied Xabier Rodríguez Calvar
<calvaris at igalia.com>'s request for review:
Bug 90284: [GTK] WebKit test runner ignores all system environment variables
https://bugs.webkit.org/show_bug.cgi?id=90284

Attachment 150189: Patch
https://bugs.webkit.org/attachment.cgi?id=150189&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
Philippe is right. This is the opposite of what you're supposed to be doing; we
don't want unexpected variables to have an effect. Feel free to add the ones
you want to pass through, but we should be able to see a deterministic list of
what can affect the runner.


More information about the webkit-reviews mailing list