[webkit-reviews] review granted: [Bug 90259] Textarea unnecessarily saves the value in some cases : [Attachment 150117] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 29 02:18:08 PDT 2012
Hajime Morrita <morrita at google.com> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 90259: Textarea unnecessarily saves the value in some cases
https://bugs.webkit.org/show_bug.cgi?id=90259
Attachment 150117: Patch
https://bugs.webkit.org/attachment.cgi?id=150117&action=review
------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=150117&action=review
Code is OK. added some nits.
> LayoutTests/fast/forms/textarea/textarea-state-restore.html:16
> + document.write('<div id=parent><form id=form1
action="data:text/html,<script>history.back()</script>">');
Could the test data more readable?
It's hard to see compare HTML between two stages.
I think it's better to have small duplication to improve readability.
More information about the webkit-reviews
mailing list