[webkit-reviews] review granted: [Bug 84540] JS binding code generator doesn't handle "attribute unsigned long[]" well : [Attachment 150115] Updated Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>'s request for review:
Bug 84540: JS binding code generator doesn't handle "attribute unsigned long[]"
well
https://bugs.webkit.org/show_bug.cgi?id=84540

Attachment 150115: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=150115&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150115&action=review


OK!

> Source/WebCore/bindings/js/JSDOMBinding.h:306
> +    template<>
> +    struct Traits<float> {
> +	   static inline JSC::JSValue arrayJSValue(JSC::ExecState*,
JSDOMGlobalObject*, const float& value)
> +	   {
> +	       return JSC::jsNumber(value);
> +	   }
> +    };

We might have discussed this before, but what is the reason why JSC needs
Traits<float> but V8 does not need Traits<float>? (Anyway you can fix it in a
follow-up patch, if needed.)