[webkit-reviews] review granted: [Bug 90027] Add support for preciseTime() to WebKitTestRunner : [Attachment 149642] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 90027: Add support for preciseTime() to WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=90027

Attachment 149642: Patch
https://bugs.webkit.org/attachment.cgi?id=149642&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=149642&action=review


> Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:625
> +    return JSValueMakeNumber(context, WTF::currentTime());

The WTF prefix should not be needed here.

> Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:35
> +	   object preciseTime();

Don’t we have bindings for double? Why does this have to be done with a general
purpose value? Clearly, the terminology is wrong, by the way, because the value
will not be an object.