[webkit-reviews] review granted: [Bug 87874] [chromium] Expose device scale factor in WebPluginContainer : [Attachment 149089] Patch to address feedback, add pageScaleFactor
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 26 17:58:18 PDT 2012
Adam Barth <abarth at webkit.org> has granted Josh Horwich
<jhorwich at chromium.org>'s request for review:
Bug 87874: [chromium] Expose device scale factor in WebPluginContainer
https://bugs.webkit.org/show_bug.cgi?id=87874
Attachment 149089: Patch to address feedback, add pageScaleFactor
https://bugs.webkit.org/attachment.cgi?id=149089&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149089&action=review
This looks fine. One silly nit below. Please feel encouraged to upload a new
patch with the nit fixed an to set the commit-queue flag to ?. That requests a
committer to mark your patch for commit via the bot.
> Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:268
> + return 1.0;
Bad indent, should be four spaces.
More information about the webkit-reviews
mailing list