[webkit-reviews] review granted: [Bug 89736] REGRESSION(r117738): validationMessage IDL attribute should not have range overflow message if value isn't range overflow : [Attachment 148971] Patch 1

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted yosin at chromium.org's request for
review:
Bug 89736: REGRESSION(r117738): validationMessage IDL attribute should not have
range overflow message if value isn't range overflow
https://bugs.webkit.org/show_bug.cgi?id=89736

Attachment 148971: Patch 1
https://bugs.webkit.org/attachment.cgi?id=148971&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148971&action=review




The code change and the tests are good.  Please fix ChangeLog before landing.



> Source/WebCore/ChangeLog:3
> +	   [REGRESSION:117738][Forms] validationMessage IDL attribute should
not have range overflow message if value isn't range overflow

Please follow a style we usually use for a regression.	This should be 
REGRESSION(r117738): ...

> LayoutTests/ChangeLog:3
> +	   [REGRESSION:117738][Forms] validationMessage IDL attribute should
not have range overflow message if value isn't range overflow

ditto.

> LayoutTests/ChangeLog:11
> +	   Expected texts are for ENABLE_INPUT_TYPE_DATE=1 and
ENABLE_INPUT_TYPE_RANGE=1.
> +	   Ports don't enable one of them should update test expectations.

We have no ENABLE_INPUT_TYPE_RANGE.