[webkit-reviews] review granted: [Bug 89517] Web Inspector: ExtensionPanel.onSearch listener doesn't work : [Attachment 148970] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 22 00:20:53 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has granted Jan Keromnes
<janx at chromium.org>'s request for review:
Bug 89517: Web Inspector: ExtensionPanel.onSearch listener doesn't work
https://bugs.webkit.org/show_bug.cgi?id=89517

Attachment 148970: Patch
https://bugs.webkit.org/attachment.cgi?id=148970&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148970&action=review


> Source/WebCore/inspector/front-end/ExtensionPanel.js:150
> +	   WebInspector.extensionServer.notifySearchAction(this._panelName,
WebInspector.extensionAPI.panels.SearchAction.CancelSearch);

Here and below, please use this.name instead of this._panelName as the latter
is private for Panel.js file.


More information about the webkit-reviews mailing list