[webkit-reviews] review granted: [Bug 89724] Make HTMLDocumentParser::create(DocumentFragment*, Element*, FragmentScriptingPermission) private. : [Attachment 148932] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 21 19:28:21 PDT 2012
Darin Adler <darin at apple.com> has granted Kwang Yul Seo
<skyul at company100.net>'s request for review:
Bug 89724: Make HTMLDocumentParser::create(DocumentFragment*,Element*,
FragmentScriptingPermission) private.
https://bugs.webkit.org/show_bug.cgi?id=89724
Attachment 148932: Patch
https://bugs.webkit.org/attachment.cgi?id=148932&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=148932&action=review
> Source/WebCore/html/parser/HTMLDocumentParser.h:93
> + // Used by parseDocumentFragment
Normally we don’t write comments like this. We can learn the same thing by
searching the code. And this could easily get out of date.
Also, there is a missing period here, since we use sentence style for comments.
More information about the webkit-reviews
mailing list