[webkit-reviews] review granted: [Bug 89728] BitmapImage duplicates code to calculate size : [Attachment 148938] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 89728: BitmapImage duplicates code to calculate size
https://bugs.webkit.org/show_bug.cgi?id=89728

Attachment 148938: Patch
https://bugs.webkit.org/attachment.cgi?id=148938&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=148938&action=review


> Source/WebCore/ChangeLog:21
> +	   * platform/graphics/BitmapImage.cpp:
> +	   (WebCore::BitmapImage::updateSize):
> +	   (WebCore):
> +	   (WebCore::BitmapImage::size):
> +	   (WebCore::BitmapImage::sizeRespectingOrientation):
> +	   * platform/graphics/BitmapImage.h:
> +	   (BitmapImage):

I really like per-function comments, and here they would be so easy to write!

> Source/WebCore/platform/graphics/BitmapImage.cpp:183
>      if (m_sizeAvailable && !m_haveSize) {

Might be nice to use early return since this function now is only about
updating.

> Source/WebCore/platform/graphics/BitmapImage.h:267
> +    void updateSize() const;

This could be private rather than protected.