[webkit-reviews] review canceled: [Bug 89336] [GTK] Add a new webkit2 tests slave bot : [Attachment 148753] Patch

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has canceled  review:
Bug 89336: [GTK] Add a new webkit2 tests slave bot
https://bugs.webkit.org/show_bug.cgi?id=89336

Attachment 148753: Patch
https://bugs.webkit.org/attachment.cgi?id=148753&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148753&action=review


Remove r+, because it was rolled out.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:143
> +			 "slavenames": ["gtk-linux-slave-2"], "triggers":
["gtk-linux-64-release-tests-wk2"]

The problem is that BuildAndTestFactory's contstructor 
can't handle triggers, now only BuildFactory can do it.

You have 2 options to fix it:
- Add triggers to BuildFactory similar to BuildAndTestFactory
- Modify gtk-linux-slave-2 from BuildAndTest to Build with trigger the WK1 and
WK2 tester