[webkit-reviews] review denied: [Bug 89244] Web Inspector: Add progress events to the timeline to keep track of how much the main frame has loaded : [Attachment 148850] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 21 12:39:43 PDT 2012
Rob Buis <rwlbuis at gmail.com> has denied Hanna <hanma at rim.com>'s request for
review:
Bug 89244: Web Inspector: Add progress events to the timeline to keep track of
how much the main frame has loaded
https://bugs.webkit.org/show_bug.cgi?id=89244
Attachment 148850: Patch
https://bugs.webkit.org/attachment.cgi?id=148850&action=review
------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=148850&action=review
Looks good but ChangeLog can be improved.
> Source/WebCore/ChangeLog:5
> + keep track of the amount of data loaded.
This seems wrong, you should just put the bug title here.
> Source/WebCore/ChangeLog:9
> +
You can move the above description to here.
> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:543
> + }
Inconsistent use of braces, I'd advise not using braces for this if section.
> LayoutTests/ChangeLog:4
> + timeline network received data event.
Just state bug title here.
> LayoutTests/ChangeLog:8
> +
You can move the above description to here.
More information about the webkit-reviews
mailing list