[webkit-reviews] review denied: [Bug 89661] Web Inspector: Properly display native memory sizes bigger than 2GB : [Attachment 148796] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 21 07:32:54 PDT 2012
Yury Semikhatsky <yurys at chromium.org> has denied Alexei Filippov
<alexeif at chromium.org>'s request for review:
Bug 89661: Web Inspector: Properly display native memory sizes bigger than 2GB
https://bugs.webkit.org/show_bug.cgi?id=89661
Attachment 148796: Patch
https://bugs.webkit.org/attachment.cgi?id=148796&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148796&action=review
> Source/WebCore/inspector/InspectorMemoryAgent.cpp:340
> + jsHeapAllocated->setSize(static_cast<double>(totalJSHeapSize));
int to double conversion shouldn't require static_cast, pleas remove it.
More information about the webkit-reviews
mailing list