[webkit-reviews] review granted: [Bug 88663] Renamed DeviceOrientation to DeviceOrientationData : [Attachment 146863] Patch

[bugzilla-daemon at webkit.org]

Steve Block <steveblock at google.com> has granted Amy Ousterhout
<aousterh at chromium.org>'s request for review:
Bug 88663: Renamed DeviceOrientation to DeviceOrientationData
https://bugs.webkit.org/show_bug.cgi?id=88663

Attachment 146863: Patch
https://bugs.webkit.org/attachment.cgi?id=146863&action=review

------- Additional Comments from Steve Block <steveblock at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=146863&action=review


I don't have a strong opinion between DeviceOrientation vs
DeviceOrientationData, but agree that consistency is a good idea.

> Source/WebCore/dom/DeviceOrientationData.cpp:1
> +/*

This might just be a display problem with the review tool, but I'm concerned
that this isn't showing up as a rename+modify of DeviceOrientation.cpp, as we
want to retain version history across the rename. Does it look OK on your
client?