[webkit-reviews] review denied: [Bug 89172] [Shadow] parentTreeScope() of nested shadow DOM subtree returns document(). : [Attachment 147770] Patch

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has denied Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 89172: [Shadow] parentTreeScope() of nested shadow DOM subtree returns
document().
https://bugs.webkit.org/show_bug.cgi?id=89172

Attachment 147770: Patch
https://bugs.webkit.org/attachment.cgi?id=147770&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=147770&action=review


> Source/WebCore/testing/Internals.cpp:208
> +Node* Internals::parentTreeScopeRootNode(Node* node, ExceptionCode& ec)

Why not just pass a TreeScope and make this parentScope() or something?
I hope Internals APIs be a set of thin wrappers of private DOM API to make them
orthogonal.