[webkit-reviews] review denied: [Bug 89584] Web Inspector: Forward message loop instrumentation data to frontend. : [Attachment 148703] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 20 19:14:03 PDT 2012
Pavel Feldman <pfeldman at chromium.org> has denied eustas.bug at gmail.com's request
for review:
Bug 89584: Web Inspector: Forward message loop instrumentation data to
frontend.
https://bugs.webkit.org/show_bug.cgi?id=89584
Attachment 148703: Patch
https://bugs.webkit.org/attachment.cgi?id=148703&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148703&action=review
> Source/WebCore/inspector/InspectorTimelineAgent.cpp:451
> void InspectorTimelineAgent::setHeapSizeStatistic(InspectorObject* record)
setHeapSizeStatistics
> Source/WebCore/inspector/InspectorTimelineAgent.cpp:456
> + if (record->getString("type", &type) && type == program)
I'd rather not call setHeapSizeStatistics for Program type.
> Source/WebCore/inspector/front-end/MemoryStatistics.js:260
> + var record = event.data;
We should not expect counters in the second-level records only. When we fix the
GC to be synchronous, the counters should only stay in Parse, Script and GC
records (maybe the whitelist is longer).
> Source/WebCore/inspector/front-end/TimelineFrameController.js:69
> + records.forEach(this._innerAddRecord, this);
DFS?
More information about the webkit-reviews
mailing list