[webkit-reviews] review denied: [Bug 87503] [Gtk] Add support for the Gamepad API : [Attachment 148341] Patch for review

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 87503: [Gtk] Add support for the Gamepad API
https://bugs.webkit.org/show_bug.cgi?id=87503

Attachment 148341: Patch for review
https://bugs.webkit.org/attachment.cgi?id=148341&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=148341&action=review


Patch looks good to me, setting r- only because of the build issues. I guess we
should update the jhbuild moduleset to add gudev as a dependency or make
gamepad optional and only fail in configure if --enable-gamepad has been
explicitly passed and gudev is not found

> Source/WebCore/platform/gtk/GamepadsGtk.cpp:89
> +    if (error)
> +	   return error->code == G_IO_ERROR_WOULD_BLOCK;

It's very unlikely but this could be true for an error in a different domain
with the same code than would block. To be extra sure you could use:

g_error_matches(error.get(), G_IO_ERROR, G_IO_ERROR_WOULD_BLOCK)

> Source/WebCore/platform/gtk/GamepadsGtk.cpp:119
> +    static const gchar* subsystems[] = { "input", 0 };

Use char instead of gchar here.

> Source/WebCore/platform/linux/GamepadDeviceLinux.h:32
> +#include <wtf/PassOwnPtr.h>

Do you need PassOwnPtr.h here? I think it could be moved to GamepadsGtk.cpp