[webkit-reviews] review granted: [Bug 89476] Web Inspector: mark used/allocated JS heap on the native memory bar chart. : [Attachment 148345] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Alexei Filippov
<alexeif at chromium.org>'s request for review:
Bug 89476: Web Inspector: mark used/allocated JS heap on the native memory bar
chart.
https://bugs.webkit.org/show_bug.cgi?id=89476

Attachment 148345: Patch
https://bugs.webkit.org/attachment.cgi?id=148345&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148345&action=review


> Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:382
> +    this._unused = {};

Should we use one map name -> structure describing barDiv instead?

> Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:473
> +	       var subChildrenSize = 0;

usedSize?