[webkit-reviews] review denied: [Bug 89158] test-webkitpy: add a -p flag to pass through captured output to enable debugging : [Attachment 147715] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel (OOO until 6/19) <eric at webkit.org> has denied Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 89158: test-webkitpy: add a -p flag to pass through captured output to
enable debugging
https://bugs.webkit.org/show_bug.cgi?id=89158

Attachment 147715: Patch
https://bugs.webkit.org/attachment.cgi?id=147715&action=review

------- Additional Comments from Eric Seidel (OOO until 6/19) <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147715&action=review


> Tools/Scripts/webkitpy/common/system/outputcapture.py:41
> +# By default we capture the output to a stream. Other modules may override
> +# this function in order to do things like pass through the output. See
> +# webkitpy.test.main for an example.
> +def stream_wrapper(stream):
> +    return StringIO()

Why not have this as a class method/object on outputcaputure.OutputCapture? 
Couldn't you then just do outputcapture.OutputCapture.stream_wrapper = Tee to
override it?

> Tools/Scripts/webkitpy/test/main.py:198
> +class Tee(object):

We have a Tee object in deprecatedlogging.py  Maybe we should split out a
tee.py file?