[webkit-reviews] review denied: [Bug 69360] new-run-webkit-tests appends "/Debug" or "/Release" to $WEBKITOUTPUTDIR : [Attachment 148174] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 19 09:01:38 PDT 2012


Eric Seidel (OOO until 6/19) <eric at webkit.org> has denied Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 69360: new-run-webkit-tests appends "/Debug" or "/Release" to
$WEBKITOUTPUTDIR
https://bugs.webkit.org/show_bug.cgi?id=69360

Attachment 148174: Patch
https://bugs.webkit.org/attachment.cgi?id=148174&action=review

------- Additional Comments from Eric Seidel (OOO until 6/19) <eric at webkit.org>
I don't understand what this does.  It seems like it woule be possible to test
that Config with a MockExecutive makes the right call.. so we should test that,
no?


More information about the webkit-reviews mailing list