[webkit-reviews] review requested: [Bug 88793] Implement undoscope attribute. : [Attachment 148329] patch3
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 19 07:24:31 PDT 2012
Rakesh <rakesh.kn at motorola.com> has asked for review:
Bug 88793: Implement undoscope attribute.
https://bugs.webkit.org/show_bug.cgi?id=88793
Attachment 148329: patch3
https://bugs.webkit.org/attachment.cgi?id=148329&action=review
------- Additional Comments from Rakesh <rakesh.kn at motorola.com>
Addressed review comments.
> This output isn't helpful because I can't see what div1 is. I would have
added a function like createElement and used evalAndLog like this:
> evalAndLog("div1 = createElement('div', {'undoscope':null, 'contenteditable:
'true'});");
Do we have any way in testharness.js to log something like this. As of now I
have added some description to each step.
More information about the webkit-reviews
mailing list