[webkit-reviews] review denied: [Bug 89455] Web Inspector: exception in console when showing popover for a big array : [Attachment 148327] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 19 07:23:56 PDT 2012
Pavel Feldman <pfeldman at chromium.org> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 89455: Web Inspector: exception in console when showing popover for a big
array
https://bugs.webkit.org/show_bug.cgi?id=89455
Attachment 148327: Patch
https://bugs.webkit.org/attachment.cgi?id=148327&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148327&action=review
Adding a test would be great.
> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:614
> + arrayFragment.getAllProperties(processProperties.bind(this));
When does this happen? The method above should either return proper value or
not be called. Could you provide a test case?
More information about the webkit-reviews
mailing list