[webkit-reviews] review denied: [Bug 87856] Web Inspector: Add getMetadata command and gotMetadata event to FileSystem : [Attachment 148285] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Taiju Tsuiki
<tzik at chromium.org>'s request for review:
Bug 87856: Web Inspector: Add getMetadata command and gotMetadata event to
FileSystem
https://bugs.webkit.org/show_bug.cgi?id=87856

Attachment 148285: Patch
https://bugs.webkit.org/attachment.cgi?id=148285&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148285&action=review


> Source/WebCore/inspector/Inspector.json:1456
> +		   "name": "getMetadata",

requestMetadata (since the result is reported asynchronously)

> Source/WebCore/inspector/Inspector.json:1458
> +		       { "name": "requestId", "type": "integer", "description":
"Request Identifier of the command. The backend should pass back this value on
corresponding gotMetadata event." },

Please typedef the type. You should also make backend generate it and return
here to guarantee it is unique.

> Source/WebCore/inspector/Inspector.json:1484
> +		   "name": "gotMetadata",

metadataReceived (since we always put subject first in the notification naming)


> LayoutTests/http/tests/inspector/filesystem/filesystem-test.js:107
> +    function gotFileSystem(fileSystem)

We use didGet notation in the rest of the inspector code.