[webkit-reviews] review denied: [Bug 80444] Add a Setting to expose quantized, rate-limited MemoryInfo values : [Attachment 148287] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 19 06:48:05 PDT 2012


Eric Seidel (OOO until 6/19) <eric at webkit.org> has denied Adam Barth
<abarth at webkit.org>'s request for review:
Bug 80444: Add a Setting to expose quantized, rate-limited MemoryInfo values
https://bugs.webkit.org/show_bug.cgi?id=80444

Attachment 148287: Patch
https://bugs.webkit.org/attachment.cgi?id=148287&action=review

------- Additional Comments from Eric Seidel (OOO until 6/19) <eric at webkit.org>
It would be really really nice to unit-test this quantize function.  It's where
this security comes from, no?

Also, we could/should test that this is accessbile (but non-updating) in a
LayoutTest, no?  I worry that if this is not tested it will be broken/insecure.
:(


More information about the webkit-reviews mailing list