[webkit-reviews] review granted: [Bug 89314] [GStreamer] optimize ::naturalSize() : [Attachment 148020] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 89314: [GStreamer] optimize ::naturalSize()
https://bugs.webkit.org/show_bug.cgi?id=89314

Attachment 148020: Patch
https://bugs.webkit.org/attachment.cgi?id=148020&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148020&action=review


> Source/WebCore/platform/graphics/gstreamer/GStreamerVersioning.cpp:24
>  #include "GStreamerVersioning.h"
>  
> +#include <gst/gst.h>

No space necessary here.

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1679

> +    m_videoSinkPad = adoptGRef(gst_element_get_static_pad(m_webkitVideoSink,
"sink"));

Are there any situations where the sink can change?