[webkit-reviews] review granted: [Bug 89319] It should be possible to look at disassembly : [Attachment 148034] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 17 19:13:48 PDT 2012


Sam Weinig <sam at webkit.org> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 89319: It should be possible to look at disassembly
https://bugs.webkit.org/show_bug.cgi?id=89319

Attachment 148034: the patch
https://bugs.webkit.org/attachment.cgi?id=148034&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=148034&action=review


> Source/WTF/wtf/Platform.h:888
> +#if !defined(ENABLE_UDIS86) && ENABLE(JIT) && PLATFORM(MAC) && (CPU(X86) ||
CPU(X86_64))
> +#define ENABLE_UDIS86 1
> +#endif

This should probably be a USE().


More information about the webkit-reviews mailing list