[webkit-reviews] review denied: [Bug 89106] Web Inspector: Implement native memory bar diagram : [Attachment 147852] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 15 10:42:01 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has denied Alexei Filippov
<alexeif at chromium.org>'s request for review:
Bug 89106: Web Inspector: Implement native memory bar diagram
https://bugs.webkit.org/show_bug.cgi?id=89106

Attachment 147852: Patch
https://bugs.webkit.org/attachment.cgi?id=147852&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147852&action=review


> Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js:475
> +	   for (var i = 0; i < memoryBlock.children.length; ++i) {

You should render it using DOM instead!


More information about the webkit-reviews mailing list