[webkit-reviews] review granted: [Bug 89203] Web Inspector: Add heap profiler owned memory to the pie chart : [Attachment 147801] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Alexei Filippov
<alexeif at chromium.org>'s request for review:
Bug 89203: Web Inspector: Add heap profiler owned memory to the pie chart
https://bugs.webkit.org/show_bug.cgi?id=89203

Attachment 147801: Patch
https://bugs.webkit.org/attachment.cgi?id=147801&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147801&action=review


> Source/WebCore/bindings/js/ScriptProfiler.h:77
> +    static size_t getProfileDataSize() { return 0; }

Please do not use get prefixes as per WebKit guidelines.

> Source/WebCore/bindings/v8/ScriptProfiler.cpp:199
> +size_t ScriptProfiler::getProfileDataSize()

profilerSnapshotsSize

> Source/WebCore/inspector/InspectorMemoryAgent.cpp:69
> +static const char jsProfilerData[] = "JSProfilerData";

InspectorData

> Source/WebCore/inspector/InspectorMemoryAgent.cpp:351
> +static PassRefPtr<InspectorMemoryBlock> jsProfilerData()

inspectorData