[webkit-reviews] review granted: [Bug 88601] Worker tear-down can re-enter JSC during GC finalization pt. 2 : [Attachment 147467] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 88601: Worker tear-down can re-enter JSC during GC finalization pt. 2
https://bugs.webkit.org/show_bug.cgi?id=88601

Attachment 147467: Patch
https://bugs.webkit.org/attachment.cgi?id=147467&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147467&action=review


Consider changing "can" to "may" (not critical but nice).

> Source/WebCore/workers/WorkerMessagingProxy.cpp:357
>      m_workerObject = 0;

What about setting m_askedToTerminate?

Actually.... I think I'm ok with not setting that here. I think it will be ok
since the exact moment on workerObjectDestruction isn't really exposed
anywhere.

> Source/WebCore/workers/WorkerMessagingProxy.cpp:363
> +    proxy->m_canBeDestroyed = true;

may is more correct than can (imo of course).