[webkit-reviews] review denied: [Bug 88950] [Blackberry] add a new Api named setAllowNotification : [Attachment 147468] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 13 19:39:09 PDT 2012
Antonio Gomes <tonikitoo at webkit.org> has denied Chris.Guan
<chris.guan at torchmobile.com.cn>'s request for review:
Bug 88950: [Blackberry] add a new Api named setAllowNotification
https://bugs.webkit.org/show_bug.cgi?id=88950
Attachment 147468: Patch
https://bugs.webkit.org/attachment.cgi?id=147468&action=review
------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147468&action=review
> Source/WebKit/blackberry/Api/WebPage.cpp:6358
> +#if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
> +void WebPage::setAllowNotification(const WebString& domain, bool allow)
> +{
> +
static_cast<NotificationPresenterImpl*>(NotificationPresenterImpl::instance())-
>onPermission(domain.utf8(), allow);
> +}
> +#endif
I am not sure I like the whole method being wrapped by #if. If you disable it,
how will the client side build? the #if macro is not visible outside webkit.
> Source/WebKit/blackberry/Api/WebPage.h:270
>
> + void setAllowNotification(const WebString& domain, bool allow);
> +
you did not wrap the method in the header.
More information about the webkit-reviews
mailing list