[webkit-reviews] review granted: [Bug 85442] Add dpcm to css3-images image-resolution : [Attachment 147232] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 13 10:05:48 PDT 2012
Tony Chang <tony at chromium.org> has granted David Barr
<davidbarr at chromium.org>'s request for review:
Bug 85442: Add dpcm to css3-images image-resolution
https://bugs.webkit.org/show_bug.cgi?id=85442
Attachment 147232: Patch
https://bugs.webkit.org/attachment.cgi?id=147232&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147232&action=review
> Source/WebCore/ChangeLog:14
> + * css/CSSGrammar.y:
> + * css/CSSParser.cpp:
> + (WebCore::CSSParser::validUnit):
> + (WebCore::CSSParser::createPrimitiveNumericValue):
> + (WebCore::unitFromString):
It's good to explain what you're changing in this section of the ChangeLog
entry.
More information about the webkit-reviews
mailing list