[webkit-reviews] review denied: [Bug 88999] After Editor::setComposition is called, input should scroll to the end of the composition. : [Attachment 147317] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied	review:
Bug 88999: After Editor::setComposition is called, input should scroll to the
end of the composition.
https://bugs.webkit.org/show_bug.cgi?id=88999

Attachment 147317: Patch
https://bugs.webkit.org/attachment.cgi?id=147317&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147317&action=review


I don't think that this is much of an improvement. The changed part of a
composition is not necessarily at the end.

This bug never says what end user scenario it attempts to fix. From what I can
reconstruct by looking at the regression test, this already works fine in
Safari. so, the right fix would be to find out what's the difference with your
port.

> Source/WebCore/editing/Editor.cpp:2310
> +	  
revealSelectionAfterEditingOperation(ScrollAlignment::alignToEdgeIfNeeded,
true);

Please don't add new boolean arguments - they make call sites like this nearly
unreadable.

Preferred WebKit style is to either add a new function with an appropriate
name, or to add a enum with named value for such arguments.