[webkit-reviews] review granted: [Bug 88918] Cast paddings to int in RenderTableCell : [Attachment 147165] Patch

[bugzilla-daemon at webkit.org]

Levi Weintraub <leviw at chromium.org> has granted Emil A Eklund
<eae at chromium.org>'s request for review:
Bug 88918: Cast paddings to int in RenderTableCell
https://bugs.webkit.org/show_bug.cgi?id=88918

Attachment 147165: Patch
https://bugs.webkit.org/attachment.cgi?id=147165&action=review

------- Additional Comments from Levi Weintraub <leviw at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147165&action=review


You need to also update the test expectations files to prevent the bots from
going red on non-linux platforms. With that r=me.

> Source/WebCore/rendering/RenderTableCell.cpp:228
> -    return computedCSSPaddingBefore() + intrinsicPaddingBefore();
> +    return static_cast<int>(computedCSSPaddingBefore() +
intrinsicPaddingBefore());

Only casting the computedCSSPaddingBefore would save unnecessarily promoting
intrinsicPaddingBefore to a LayoutUnit.