[webkit-reviews] review granted: [Bug 88451] Extra HandleScope in V8Proxy : [Attachment 146372] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 13 10:00:05 PDT 2012

Adam Barth <abarth at webkit.org> has granted Eriq Augustine
<eaugusti at chromium.org>'s request for review:
Bug 88451: Extra HandleScope in V8Proxy

Attachment 146372: Patch

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146372&action=review

> Source/WebCore/bindings/v8/V8Proxy.cpp:263
> +	   if (evaluationResult.IsEmpty())
> +	       evaluationResult = v8::Local<v8::Value>::New(v8::Undefined());

Does this line make sense?  I thought empty handles and v8::Undefined where the

More information about the webkit-reviews mailing list