[webkit-reviews] review denied: [Bug 88988] Web Inspector: DebuggerModel should support setting breakpoints without script by sourceURL only. : [Attachment 147294] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 88988: Web Inspector: DebuggerModel should support setting breakpoints
without script by sourceURL only.
https://bugs.webkit.org/show_bug.cgi?id=88988

Attachment 147294: Patch
https://bugs.webkit.org/attachment.cgi?id=147294&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147294&action=review


> Source/WebCore/inspector/front-end/DebuggerModel.js:59
> +WebInspector.DebuggerModel.Location = function(scriptId, sourceURL,
lineNumber, columnNumber)

Shouldn't sourceURL be optional for debugger location? For example it does not
exist for eval scripts.

> Source/WebCore/inspector/front-end/DebuggerModel.js:136
>      setBreakpointByScriptLocation: function(rawLocation, condition,
callback)

Should we be more specific here and introduce another method instead?