[webkit-reviews] review denied: [Bug 88602] Web Inspector: FileSystem tree should hide uninitialized FileSystem : [Attachment 147237] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 13 05:48:50 PDT 2012

Vsevolod Vlasov <vsevik at chromium.org> has denied Taiju Tsuiki
<tzik at chromium.org>'s request for review:
Bug 88602: Web Inspector: FileSystem tree should hide uninitialized FileSystem

Attachment 147237: Patch

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=147237&action=review

> Source/WebCore/inspector/Inspector.json:1408
> +		   "id": "Entry",

Could you please make sure every type, property, command and event in
FileSystem domain has a description, and that description is the last property
for each of them?
Could you please make corresponding drive-by changes to entities added in
previous patch as well.

> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:2
> + * Copyright (C) 2011, 2012 Google Inc. All rights reserved.

I believe part of this patch (e.g. this line) was already landed, could you
please rebaseline?

More information about the webkit-reviews mailing list