[webkit-reviews] review requested: [Bug 88399] [WK2] Add implementation for registerIntentService in WebFrameLoaderClient : [Attachment 147271] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 13 03:09:11 PDT 2012
Christophe Dumez <christophe.dumez at intel.com> has asked for review:
Bug 88399: [WK2] Add implementation for registerIntentService in
WebFrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=88399
Attachment 147271: Patch
https://bugs.webkit.org/attachment.cgi?id=147271&action=review
------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
Take Kenneth's feedback into consideration:
- Change license headers
- Remove the extra notImplemented() in WebFrameLoaderClient.cpp
- Move empty destructor from implementation to header (WebIntentServiceInfo)
- Use WebIntentServiceInfo instead of IntentServiceInfo in WebLoaderClient
I kept the rest as is for now (please see my previous comments).
More information about the webkit-reviews
mailing list