[webkit-reviews] review canceled: [Bug 88399] [WK2] Add implementation for registerIntentService in WebFrameLoaderClient : [Attachment 146217] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 13 03:09:11 PDT 2012


Christophe Dumez <christophe.dumez at intel.com> has canceled Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 88399: [WK2] Add implementation for registerIntentService in
WebFrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=88399

Attachment 146217: Patch
https://bugs.webkit.org/attachment.cgi?id=146217&action=review

------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
Take Kenneth's feedback into consideration:
- Change license headers
- Remove the extra notImplemented() in WebFrameLoaderClient.cpp
- Move empty destructor from implementation to header (WebIntentServiceInfo)
- Use WebIntentServiceInfo instead of IntentServiceInfo in WebLoaderClient

I kept the rest as is for now (please see my previous comments).


More information about the webkit-reviews mailing list