[webkit-reviews] review granted: [Bug 84303] IndexedDB: Inspector should handle null, string, and array keyPaths : [Attachment 146607] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 9 03:50:52 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 84303: IndexedDB: Inspector should handle null, string, and array keyPaths
https://bugs.webkit.org/show_bug.cgi?id=84303

Attachment 146607: Patch
https://bugs.webkit.org/attachment.cgi?id=146607&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146607&action=review


> Source/WebCore/inspector/front-end/IndexedDBViews.js:170
> +	   keyColumnHeaderFragment.appendChild(document.createTextNode(" (" +
WebInspector.UIString("keyPath") + ": "));

Do you need to localize "keyPath"? If yes, it should be UIString("(keyPath: "),
etc.


More information about the webkit-reviews mailing list