[webkit-reviews] review granted: [Bug 87270] Web Inspector: Limit DebuggerAgent.Location use to DebuggerModel only, introduce WebInspector.RawLocation to be used elsewhere. : [Attachment 146055] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 87270: Web Inspector: Limit DebuggerAgent.Location use to DebuggerModel
only, introduce WebInspector.RawLocation to be used elsewhere.
https://bugs.webkit.org/show_bug.cgi?id=87270

Attachment 146055: Patch
https://bugs.webkit.org/attachment.cgi?id=146055&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146055&action=review


> Source/WebCore/inspector/front-end/DebuggerModel.js:218
> +	   var rawLocation = /** @type {WebInspector.DebuggerModel.Location} */
location;

There is no need for this cast

> Source/WebCore/inspector/front-end/UISourceCode.js:434
> +WebInspector.RawLocation = function()

Could you remind me why this one does not have lineNumber, columnNumber
members?