[webkit-reviews] review granted: [Bug 88677] [GTK] build accelerated compositing on by default if OpenGL is present : [Attachment 146620] Patch

[bugzilla-daemon at webkit.org]

Alejandro G. Castro <alex at igalia.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 88677: [GTK] build accelerated compositing on by default if OpenGL is
present
https://bugs.webkit.org/show_bug.cgi?id=88677

Attachment 146620: Patch
https://bugs.webkit.org/attachment.cgi?id=146620&action=review

------- Additional Comments from Alejandro G. Castro <alex at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=146620&action=review


Looks good to me, just added some proposals.

> ChangeLog:9
> +	   Also prevent enabling WebGL is Clutter is turned on.

nit: s/is/if/

> configure.ac:533
> +			      [Select accelerated backend (Clutter currently
unsupported) [default=autodetect]]), [],

This message could be confusing because clutter is supported but no in the
detection if I understand correctly.

> configure.ac:554
>      OPENGL_LIBS="-lGL -ldl"

Would it make sense to use PKG_CHECK_MODULES with gl?

> configure.ac:572
> +if test "$enable_webgl" = "yes" && test "$with_acceleration_backend" !=
"opengl"; then

Should we use '= "clutter"' better?

> configure.ac:1262
> +if test "$with_acceleration_backend" = "clutter"; then
>     PKG_CHECK_MODULES(CLUTTER, clutter-1.0 >= $CLUTTER_REQUIRED_VERSION)
>     PKG_CHECK_MODULES([CLUTTER_GTK],
>			[clutter-gtk-1.0 >= $CLUTTER_GTK_REQUIRED_VERSION])

Isn't this if repeated?