[webkit-reviews] review granted: [Bug 87821] [Chromium] Compositor doesn't support translucent root layers. : [Attachment 146472] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted David Reveman
<reveman at chromium.org>'s request for review:
Bug 87821: [Chromium] Compositor doesn't support translucent root layers.
https://bugs.webkit.org/show_bug.cgi?id=87821

Attachment 146472: Patch
https://bugs.webkit.org/attachment.cgi?id=146472&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=146472&action=review


R=me

One other possibly complication - not with this patch but with the idea in
general - is that some callers want to use background filters for
accessibility, so they have to be really careful to not set the viewport as
transparent and try to set background filters.	I think that all we need to do
on this side is be careful in our header comments, but it's something to be
aware of.

> Source/Platform/chromium/public/WebLayerTreeView.h:121
> +    // Sets the background transparency for the viewport.

Please also document the default (I'm pretty sure it's transparent = false)

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:617
> +    // FIXME: We only allow background filters on an opaque render surface
because other surfaces may contain

could you please also update the comment on WebLayer::setBackgroundFilters?